OpenLiberty / open-liberty

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment
https://openliberty.io
Eclipse Public License 2.0
1.15k stars 592 forks source link

Enabling openidConnectClient feature causes the body request not to be forwarded to the application's servlet has been re-introduced with PR #29203 #29902

Open pellmont opened 1 week ago

pellmont commented 1 week ago

Describe the bug
Issue #28235 appears again since Release 24.0.0.9. It probably has been re-introduced with PR #29203 . In commit 582138f3dc136d3100cd98da17c1d03debb3ff1c the restore of the post params have been removed.

We are having a Rest-Service with Multipart-Form-Data (for file upload) which is having those issues.

With the current Release 24.0.0.10 we at least can mitigate the problem if we set oidcclientRequestParameterSupported to false on oidcConnectClient-Configuration in server.xml. Although this does not seem to be an official (documented) configuration Feature...

Steps to Reproduce
see #28235

Expected behavior
InputStream not to be consumed already on application level...

Diagnostic information:

ayoho commented 5 days ago

Hi, @pellmont. The Single Sign-On team will take a look when we can. And you're correct, the oidcclientRequestParameterSupported attribute is unofficial and unsupported.

ayoho commented 2 days ago

Possible related issue: https://github.com/OpenLiberty/open-liberty/issues/29746