OpenLiberty / open-liberty

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment
https://openliberty.io
Eclipse Public License 2.0
1.15k stars 589 forks source link

LG-236: Provide means to expose services like mpMetrics / mpHealth not on application port #9019

Open donbourne opened 5 years ago

donbourne commented 5 years ago

WAD: https://ibm.box.com/s/s17fwiiju9phsgfa2htg6gt7u0j5tudy

RFE: https://cloud-platform.ideas.ibm.com/ideas/TWAS-I-138

donbourne commented 4 years ago

@fmhwong can you please review the WAD (see link in top comment)?

NottyCode commented 4 years ago

@donbourne I have the following feedback:

  1. Can we get a use case defined for the collective scenario described in the admin section.
  2. The slide that contains the mapping of context roots doesn't include all the context roots of all the feature web bundles we have. I think we should iterate everything that will be on every context root.
  3. Looking at the design (and I know I was involved in the current one so this is as much feedback for me as you) it seems like it would be simpler to just say if there is a virtual host called admin_host map these context roots to it, similar for ops_host. Rather than having to define a virtual host and a variable to do the mapping. I'm not sure how easy this would be to do and I think if we were to go that direction it would need discussion as it could be a breaking change, but it would be a lot simpler and more logical so I'm wondering if it is worth discussing.
Yushan-Lin commented 4 years ago

Implementation: https://github.com/OpenLiberty/open-liberty/issues/10099

Yushan-Lin commented 4 years ago

Documentation: #10100

atosak commented 4 years ago

List of Steps to complete or get approvals / sign-offs for Onboarding to the Liberty release (GM date)

Instructions:


TARGET COMPLETION DATE Before Development Starts or 8 weeks before Onboarding