OpenLightingProject / libartnet

An Open Source implementation of the ArtNet protocol
https://www.openlighting.org/libartnet-main/
GNU Lesser General Public License v2.1
124 stars 56 forks source link

FirmwareMaster blockId issue #19

Open mcallegari opened 2 years ago

mcallegari commented 2 years ago

Hi, this line of code is suspicious: https://github.com/OpenLightingProject/libartnet/blob/61878f911f10f22d8ce109324faa345408dbb2c5/artnet/transmit.c#L349

It means blockId will never reach 255, but just 254. I tested the code with a few fixtures and they errored on the 254 -> 0 switch. Any chance this can be fixed for future versions? Thanks