search

OpenLightingProject / ola

The Open Lighting Architecture - The Travel Adaptor for the Lighting Industry
https://www.openlighting.org/ola/
Other
647 stars 205 forks source link

Python API "client.SendDmx" priority support? #1769

Open taf-dk opened 2 years ago

taf-dk commented 2 years ago

Can I somehow include the priority flag via the python API?

The reason I need it is that I would like to control the light locally via temperature probe and overwrite this with external artnet DMX input.

I guess it should be placed in the client.SendDmx(universe, data, DmxSent) function, looking at the link below.

http://docs.openlighting.org/ola/doc/latest/structola_1_1client_1_1_send_d_m_x_args.html

My code: code.txt

peternewman commented 2 years ago

Hi @taf-dk ,

You're right we don't currently support it: https://github.com/OpenLightingProject/ola/blob/e95de59a04c79ddd6ba745578e4183301f4b98b7/python/ola/OlaClient.py#L937-L965

I think we'd be able to add it fairly easily, but it would need a new method to deal with the extra parameter SendDmxPriority(universe, data, priority, DmxSent).

Can't you work around it though; the default priority should be followed by the Python stuff (i.e. 100), so can't you just set your Art-Net port to use a higher priority and it will override it when present?

taf-dk commented 2 years ago

Hi @peternewman

Thank you for the quick reply, changing the priority for the artnet input from 100 to 110 input solved the problem for my use case.

peternewman commented 2 years ago

Great, glad to hear that works, I'll leave the issue open so we can add it at some point...