OpenLightingProject / ola

The Open Lighting Architecture - The Travel Adaptor for the Lighting Industry
https://www.openlighting.org/ola/
Other
644 stars 204 forks source link

Add a static source code analyser to our GitHub Actions #1963

Open kripton opened 6 months ago

kripton commented 6 months ago

As discussed during the PlugFest, OLA might benefit from running some kind of static code analysis. While I'm perfectly open to alternatives, I do like how SonarQube / SonarCloud reports issues and there is GitHub Actions integration, including PR-annotation (as we currently do with codespell). Also, SonarCloud is free for Open Source projects:

SonarLint is completely free. SonarQube Community Edition is free. All other SonarQube editions are commercial and require a paid license. SonarCloud is entirely free for all open source projects. You only pay if you want to analyze private repositories.

(from https://www.sonarsource.com/open-source-editions/, FAQ entry "Are the products always free? ")

Thus, I would propose to enable SonarCloud integration for OLA.

kripton commented 6 months ago

If there are no objections (looking @peternewman :D), I would install the SonarCloud app into the ola repository using my account and permissions. See: https://github.com/apps/sonarcloud

DaAwesomeP commented 6 months ago

This also goes along the lines of #1889 and #1890 which have been on the table for a bit. We should really get those reviewed/merged before considering more analysis otherwise the additional analysis may not result in improvements.

My personal C++ stack currently contains: