search

OpenLightingProject / ola

The Open Lighting Architecture - The Travel Adaptor for the Lighting Industry
https://www.openlighting.org/ola/
Other
647 stars 206 forks source link

Plugin for Digital Enlightenment / FX5 interfaces #241

Closed ola-importer closed 3 years ago

ola-importer commented 10 years ago

From marius.z...@mlba-team.de on June 15, 2013 03:07:46

Added plugin support for ubs dmx interfaces coming from digital enlightenment.

The necessary changes are contained in our github repository located at https://github.com/mlba-team/open-lighting , changesets ba94b3b43c6d846fb18c155530199e64c02eb5ac and a750505367f0d4f122b5affc93da3b09a4c44449. (See the diff attached as well)

The plugin depends on the libusbdmx driver from fx5, forked at https://github.com/mlba-team/usbdmx . Detection via autoconf was hopefully implemented correctly.

Please have a look at the changes and merge them when useful.

Thanks!

Attachment: 0001-Merged-support-for-digital-enlightenment-fx5-interfa.patch 0001-Fixed-missing-generation-of-Makefile.im-for-the-Enli.patch

Original issue: http://code.google.com/p/open-lighting/issues/detail?id=240

ola-importer commented 10 years ago

From si...@nomis52.net on June 15, 2013 19:51:32

Please push the changes to a git repo (either google code or git hub) and enable comments.

Also take a look at README.developer which points to the lint tool to run.

Status: Accepted
Owner: nomis52

ola-importer commented 10 years ago

From marius.z...@mlba-team.de on June 16, 2013 11:01:55

I just tried to fix all isues reported by the lint tool. The code is already available on github as reported above and open for comments.

ola-importer commented 10 years ago

From si...@nomis52.net on June 18, 2013 09:55:02

Ok, I've reviewed everything except the OSC changes. Please reply here when you want me to take another look.

Status: Started

ola-importer commented 10 years ago

From marius.z...@mlba-team.de on June 25, 2013 00:12:41

I modified the enlightenment code according to your comments. Please have another look at the github repository. The only issue I cannot agree with is your discovery of a racecondition with usbdmx. I cannot find a way we could possibly synchronize this. Please also see my comment attached to yours.

ola-importer commented 10 years ago

From si...@nomis52.net on June 26, 2013 21:29:48

Yeah, the API for the driver doesn't support synchronization. I think we have 3 options:

i) merge the change as is ii) fix the usbdmx driver iii) write our own usbdmx driver

i) is undesirable and I'm not sure ii) is an option.

iii) is the most work but looking at the code it's around 1000 lines of code (hidapi.c & usbdmx.c). This has the nice property of not introducing another dependency.

Is there any documentation for the protocol used to talk to the interface?

Simon

ola-importer commented 10 years ago

From marius.z...@mlba-team.de on June 27, 2013 00:38:11

I am not aware of an official documentation. The usbdmx driver is an implementation of the api available for windows and originally coming from http://www.digital-enlightenment.de/usbdmx.htm . I'd keep the dependency as we use the "official" api for the interface this way.

If you still prefer i) I am afraid I will not have the spare time to help you over the next two or three months as I have to work on other stuff first.

Regards, Marius

ola-importer commented 10 years ago

From norre...@gmail.com on December 19, 2013 10:01:24

Just wondering: Will this be merged in the near future? Is there any work in progress on it?

ola-importer commented 10 years ago

From peterjne...@gmail.com on December 19, 2013 15:35:07

Simon is the main decision maker, but I think from the OLA perspective, we'd still be looking for ii or iii to be done. From his commit list, it doesn't look like Marius had made any commits to his OLA or usbdmx fork since the last comment (he said he was likely to be busy). So we're probably looking for him or someone else to pick it up for now.

peternewman commented 10 years ago

See also: https://github.com/fx5/usbdmx/issues/6

freundTech commented 9 years ago

Sorry for asking, but is there any progress on this?

nomis52 commented 9 years ago

We're likely to reimplement the drive from scratch in OLA (option 3). Since we don't have access to the hardware it's rather low priority at this point.

freundTech commented 9 years ago

Ok. Sadly I don't have a lot of experience in C. Otherwise I would help. I got a FX5 at home (borrowed from someone else), so I could help testing.

bitte-ein-bit commented 6 years ago

I've noticed that the DMXControl Noodle U1 is listed as supported. According to https://github.com/DMXControl/usbdmx/commit/89bc53755711236ce5fd26977f08e223df31b980 the Noodle U1 is using the same driver/protocol, if I understand right. Or at least at that time was doing so. I fail to find the code where the USB identifiers are stored, so I can test. Any hints?

peternewman commented 6 years ago

Hi @bitte-ein-bit ,

Well spotted.

Assuming you mean on the OLA side, it's here: https://github.com/OpenLightingProject/ola/blob/master/plugins/usbdmx/DMXCProjectsNodleU1Factory.cpp#L33-LL42

Have you got a Digital Enlightenment/FX5 interface then?

bitte-ein-bit commented 6 years ago

Yeah, I have a DE interface. I'll test and report back. Sometimes upper vs. lowercase search is too simple. ;-)

bitte-ein-bit commented 6 years ago

I can confirm the driver works. I tested successfully on a Raspberry Pi 1.

The only thing I sometimes have are plugins/usbdmx/AsyncUsbSender.cpp:67: Transfer returned 2 messages and then the interface does not update. But that could be anything from the PI being to weak, to a general issue with this driver and the interface or just normal... @peternewman any advise?

peternewman commented 6 years ago

So that's this line here: https://github.com/OpenLightingProject/ola/blob/master/plugins/usbdmx/AsyncUsbSender.cpp#L67

Which looking at https://github.com/libusb/libusb/blob/master/libusb/libusb.h#L1105 I think will be transfer timed out.

Have you got another Linux machine you could try it on? Is your Pi overclocked? Can you try increasing the nice level of the process?

Is it just that one update that fails, or all subsequent ones too?

peternewman commented 6 years ago

You could also try increasing https://github.com/bitte-ein-bit/ola/blob/master/plugins/usbdmx/DMXCProjectsNodleU1.cpp#L52 and see if it helps stop the issue occurring.

mkersting commented 4 years ago

Is there any news to the DE Interface?

I managed OLA to work on my Raspberry PI, I managed to see the logs when in Plug and Unplug my Interface. I manages to run the python script which comes with the DE-Interface Driver And sucessfully gave out some DMX Signals.

But I did not manage to add the Interface to OLA. ATM for me quite Frustrating, to look through Forum posts, some of them saying that they made it work (but no closer description). Others saying that the DE and FX5 Interface are not supported anymore. But the Nodle is, and what is codewise the difference to the DE and FX5 Interface?

I would be very happy to have either an old OLA Version where it works, or some News to the latest Information about this topic.

If I manage to make it work, i promise to write a "How to" Step by Step Guide :-D

In the End of my personal Project I'd Like to receive ArtNet with the RaspberryPi and send it to the Output of the DE-Interface Which makes my Raspberry Pi an "ArtNet Node". So any other Suggestions to solve this are also very welcome :-)