OpenLightingProject / ola

The Open Lighting Architecture - The Travel Adaptor for the Lighting Industry
https://www.openlighting.org/ola/
Other
645 stars 204 forks source link

E1.37-2 is getting close. We should implement the PIDs in a dummy responder. #258

Open ola-importer opened 10 years ago

ola-importer commented 10 years ago

From si...@nomis52.net on October 11, 2013 02:35:08

E137-2 is the additional pids for IP configuration. It would be good to implement these (probably just the GETs for now) so we can make sure everything is going to work as expected.

Original issue: http://code.google.com/p/open-lighting/issues/detail?id=257

ola-importer commented 10 years ago

From si...@nomis52.net on October 11, 2013 02:37:38

Cc: sms3h2 peterjne...@gmail.com

ola-importer commented 10 years ago

From peterjne...@gmail.com on October 11, 2013 04:45:06

I could probably pick it up, although not until the 24th October say, and I'll be a bit busy with work then, I'm just finishing off some more sensor stuff first. Google found this, is it the latest version of the spec? http://tsp.plasa.org/tsp/meetingfiles/cpwg/E1-37-2_IPv4MessagePIDs-Jul2013.pdf From a very quick skim, it seems like we'd probably want two implementations (a bit like the sensor stuff and the changes I'm making to that); some semi-abstract classes that model it all, and stuff in ResponderHelper that uses them, a fake concrete class in a dummy responder for edge cases and a real concrete class for general use, like the other dummy responders, the SPI stuff etc.

From the way some of these are going, OLA in general probably wants a seperate non-dummy responder, so you can manage and control it remotely via RDM; possibly even allowing universe patching and the like?

ola-importer commented 10 years ago

From si...@nomis52.net on October 11, 2013 06:46:30

Yup, that's the idea and also the most recent version of the spec.

W.R.T patching and a non-dummy responder, my plan is to develop the E1.33 code in tools/e133/ and then merge that into olad once the specification is locked down. With that in mind, if you want to add the E1.37-2 PIDs to tools/e133/ManagementEndpoint.cpp that would be helpful since that class will end up as the olad responder.

ola-importer commented 10 years ago

From peterjne...@gmail.com on October 29, 2013 11:23:04

Status: Started

ola-importer commented 10 years ago

From si...@nomis52.net on November 18, 2013 08:04:30

Owner: peterjne...@gmail.com

peternewman commented 10 years ago

Okay, all the get stuff is implemented as a dummy responder and real data in the main dummy responder. No set yet, and not in the E1.33 code yet.

nomis52 commented 10 years ago

I think we can close this.

peternewman commented 10 years ago

I'm going to re-open this for two reasons. Firstly I think it should stay open until we get the live PIDs in. Secondly I'd still like to get the set stuff working on the dummy responder.

peternewman commented 9 years ago

Live PIDs are in. I need to check if set was ever sorted on the dummy responder.