OpenLightingProject / open-fixture-library

A library and website for lighting technology's DMX fixture definition files.
https://open-fixture-library.org/
MIT License
193 stars 64 forks source link

Add fixture `varytec/led-theater-spot-120-fc` #3977

Open FloEdelmann opened 4 months ago

FloEdelmann commented 4 months ago

Fixture warnings / errors

Thank you jean7111!

github-actions[bot] commented 4 months ago

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ varytec / led-theater-spot-120-fc: d-light / attributes-correctness
  • ✔️ varytec/led-theater-spot-120-fc-6 CH.xml
✔️ varytec / led-theater-spot-120-fc: dmxcontrol3 / channel-numbers
  • ✔️ varytec-led-theater-spot-120-fc-6-CH.xml
✔️ varytec / led-theater-spot-120-fc: dragonframe / json-schema-conformity
  • ✔️ varytec/led-theater-spot-120-fc.json
  • ✔️ manufacturers.json
✔️ varytec / led-theater-spot-120-fc: millumin / json-schema-conformity
  • ✔️ varytec/led-theater-spot-120-fc.json
varytec / led-theater-spot-120-fc: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Varytec-LED-Theater-Spot-120-FC.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
varytec / led-theater-spot-120-fc: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Varytec-LED-Theater-Spot-120-FC.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
kengruven commented 4 months ago

The "Red" channel here is just wrong.

Also, this looks exactly like varytec/led-theater-spot-100 (merged by #829) but with 20% higher power. Could we simply add a note on that fixture that it works for both? Or change its title to "LED Theater Spot 100/120"?