OpenLightingProject / open-fixture-library

A library and website for lighting technology's DMX fixture definition files.
https://open-fixture-library.org/
MIT License
193 stars 64 forks source link

Add fixture `robe/robin-spiider-m1` #3986

Closed FloEdelmann closed 3 months ago

FloEdelmann commented 4 months ago

Fixture warnings / errors

Thank you BOIG Laurent!

github-actions[bot] commented 4 months ago

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

robe / robin-spiider-m1: d-light / attributes-correctness
  • ❌ robe/robin-spiider-m1-Spiider.xmlError parsing XML: Duplicate parameter name: INTENSITY/DIMMER
✔️ robe / robin-spiider-m1: dmxcontrol3 / channel-numbers
  • ✔️ robe-robin-spiider-m1-Spiider.xml
✔️ robe / robin-spiider-m1: dragonframe / json-schema-conformity
  • ✔️ robe/robin-spiider-m1.json
  • ✔️ manufacturers.json
robe / robin-spiider-m1: millumin / json-schema-conformity
  • ❌ robe/robin-spiider-m1.jsonfixture/availableChannels/Power~1Special Fonctions (type: Nothing) must NOT have more than 1 properties
    fixture/availableChannels/Power~1Special Fonctions (type: Nothing) must have required property 'name'
    fixture/availableChannels/Power~1Special Fonctions (type: Nothing) must match exactly one schema in oneOf
robe / robin-spiider-m1: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Robe-Robin-Spiider-M1.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid TILT degrees 1 definitions processed. 1 errors detected
✔️ robe / robin-spiider-m1: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Robe-Robin-Spiider-M1.qxf
kengruven commented 3 months ago

A lot of the channels here need cleaning up (e.g., Pan and Tilt are "Pan 3" and "Tilt 3"). Some channels are blank (e.g., "Power/Special Fonctions" is a single NoFunction here but actually has dozens of features, and "Shutter / Strobe" is just a single "Open" capability). "Zoom" is backwards. None of the colors are included.

The fixture has 10 modes, but only 1 is given here -- based on the count (49), it looks like what the manual calls mode "1".

This mapping may be useful to allow basic control in one mode, but it's not close to being complete yet.