OpenLightingProject / open-fixture-library

A library and website for lighting technology's DMX fixture definition files.
https://open-fixture-library.org/
MIT License
183 stars 61 forks source link

Add fixture `lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head` #3999

Open FloEdelmann opened 1 month ago

FloEdelmann commented 1 month ago

Fixture warnings / errors

Thank you @adiac!

github-actions[bot] commented 1 month ago

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: d-light / attributes-correctness
  • ✔️ lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head-11ch.xml
lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: dmxcontrol3 / channel-numbers
  • Unable to export fixture: Exporting fixture mode lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head/11ch failed: TypeError: Cannot read properties of null (reading 'type')
✔️ lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: dragonframe / json-schema-conformity
  • ✔️ lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head.json
  • ✔️ manufacturers.json
✔️ lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: millumin / json-schema-conformity
  • ✔️ lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head.json
lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/lightmaXX-Platinum-Line-MINI-EXEO-LED-25W-LED-Moving-Head.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf:Color Wheel/Dark Red/Res1: FX color Dark Red (#ff0000) should have color code #8b0000, the name for given FX color code is Red ./manufacturer/fixture.qxf: Invalid PAN degrees ./manufacturer/fixture.qxf: Invalid TILT degrees 1 definitions processed. 3 errors detected
✔️ lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/lightmaXX-Platinum-Line-MINI-EXEO-LED-25W-LED-Moving-Head.qxf
adiac commented 1 month ago

I already contacted the manufacturer for a manual and will update you if I hear back from them. I used the 13ch-var manual and tested everything with the fixture myself.

kengruven commented 1 month ago

@adiac, just curious, what software do you use to test OFL fixtures?

adiac commented 1 month ago

@kengruven, I use QLC+ 4. Which is a good software, but still gives me a lot of headache. ^^

But with testing I meant, that I just checked if the values of this manual correspond with what the fixture is actually doing.

adiac commented 1 week ago

@kengruven can this be merged or not? I would like to use the fixture definition in my program very soon.

kengruven commented 1 week ago

I said from the start that I was fine with this, but I'm not an OFL maintainer.

(Regardless of whether it's merged, though, if you want control of your fixture definitions, I think your best bet is to use your own fork, not rely on the head of someone else's repo.)