OpenLightingProject / open-fixture-library

A library and website for lighting technology's DMX fixture definition files.
https://open-fixture-library.org/
MIT License
183 stars 61 forks source link

Add fixture `generic/moving-head-zoom-wash` #4011

Open FloEdelmann opened 1 month ago

FloEdelmann commented 1 month ago

Fixture warnings / errors

Thank you Anonymous!

github-actions[bot] commented 1 month ago

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ generic / moving-head-zoom-wash: d-light / attributes-correctness
  • ✔️ generic/moving-head-zoom-wash-16ch.xml
✔️ generic / moving-head-zoom-wash: dmxcontrol3 / channel-numbers
  • ✔️ generic-moving-head-zoom-wash-16ch.xml
generic / moving-head-zoom-wash: dragonframe / json-schema-conformity
  • ❌ generic/moving-head-zoom-wash.jsonfixture/availableChannels/Pan finetune must NOT be valid
  • ✔️ manufacturers.json
generic / moving-head-zoom-wash: millumin / json-schema-conformity
  • ❌ generic/moving-head-zoom-wash.jsonfixture/availableChannels/Pan finetune (type: Nothing) must NOT have more than 1 properties
    fixture/availableChannels/Pan finetune (type: Nothing) must have required property 'name'
    fixture/availableChannels/Pan finetune (type: Nothing) must match exactly one schema in oneOf
generic / moving-head-zoom-wash: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Generic-Moving-Head-Zoom-Wash.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected ./manufacturer/fixture.qxf: Invalid PAN degrees ./manufacturer/fixture.qxf: Invalid TILT degrees ./manufacturer/fixture.qxf: Invalid power consumption 1 definitions processed. 4 errors detected
generic / moving-head-zoom-wash: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Generic-Moving-Head-Zoom-Wash.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
kengruven commented 4 weeks ago

This one is a little funny. The existing "generic" fixtures in OFL mean "this is a common DMX mapping (like RGBA) which can work with lots of fixtures, in a pinch", but this "generic" means something like "a specific fixture which is an unbranded Chinese model and has no identifiable brand/name/model number".

As for the JSON file as written: it's a good start, but it doesn't have the 24- or 32-channel modes at all, and the user manual is not very clear so there are a few channels which I wouldn't have any idea how to describe.