search

OpenLightingProject / open-fixture-library

A library and website for lighting technology's DMX fixture definition files.
https://open-fixture-library.org/
MIT License
183 stars 61 forks source link

Add fixture `aglare-led-lghting/zhenghaisheng` #4049

Closed FloEdelmann closed 6 days ago

FloEdelmann commented 6 days ago

Fixture warnings / errors

Thank you fairground lights!

github-actions[bot] commented 6 days ago

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ aglare-led-lghting / zhenghaisheng: d-light / attributes-correctness
  • ✔️ aglare-led-lghting/zhenghaisheng-amusement lights.xml
❌ aglare-led-lghting / zhenghaisheng: dmxcontrol3 / channel-numbers
  • ❌ aglare-led-lghting-zhenghaisheng-amusement-lights.xmlTypeError: Cannot read properties of undefined (reading 'filter')
❌ aglare-led-lghting / zhenghaisheng: dragonframe / json-schema-conformity
  • ❌ aglare-led-lghting/zhenghaisheng.jsonfixture/availableChannels/Dimmer must NOT be valid
  • ✔️ manufacturers.json
❌ aglare-led-lghting / zhenghaisheng: millumin / json-schema-conformity
  • ❌ aglare-led-lghting/zhenghaisheng.jsonfixture/availableChannels/Dimmer (type: Nothing) must NOT have more than 1 properties
    fixture/availableChannels/Dimmer (type: Nothing) must NOT have more than 2 properties
    fixture/availableChannels/Dimmer (type: Nothing) must match exactly one schema in oneOf
✔️ aglare-led-lghting / zhenghaisheng: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Aglare-LED-Lghting-zhenghaisheng.qxf
✔️ aglare-led-lghting / zhenghaisheng: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Aglare-LED-Lghting-zhenghaisheng.qxf
FloEdelmann commented 6 days ago

See https://github.com/OpenLightingProject/open-fixture-library/pull/4050#issuecomment-2200541989