OpenLightingProject / open-fixture-library

A library and website for lighting technology's DMX fixture definition files.
https://open-fixture-library.org/
MIT License
183 stars 61 forks source link

Add fixture `prolights/zhenghaisheng` #4050

Closed FloEdelmann closed 6 days ago

FloEdelmann commented 6 days ago

Fixture warnings / errors

Thank you @Aglare!

github-actions[bot] commented 6 days ago

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ prolights / zhenghaisheng: d-light / attributes-correctness
  • ✔️ prolights/zhenghaisheng-amusement lights.xml
✔️ prolights / zhenghaisheng: dmxcontrol3 / channel-numbers
  • ✔️ prolights-zhenghaisheng-amusement-lights.xml
✔️ prolights / zhenghaisheng: dragonframe / json-schema-conformity
  • ✔️ prolights/zhenghaisheng.json
  • ✔️ manufacturers.json
prolights / zhenghaisheng: millumin / json-schema-conformity
  • ❌ prolights/zhenghaisheng.jsonfixture/availableChannels/Green (type: Nothing) must NOT have more than 1 properties
    fixture/availableChannels/Green (type: Nothing) must NOT have more than 2 properties
    fixture/availableChannels/Green (type: Nothing) must match exactly one schema in oneOf
✔️ prolights / zhenghaisheng: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Prolights-zhenghaisheng.qxf
✔️ prolights / zhenghaisheng: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Prolights-zhenghaisheng.qxf
kengruven commented 6 days ago

4049 and #4050 are a mess, and I can't figure out what's going on here. There's company data in the fixture, there's RGB channels which are actually NoFunction, there's physical data which is obviously bogus (a 3-pin DMX connector in 3x2mm?), there's fake RDM IDs, and there's categories which make no sense.

The linked video says it's for a "YJLED-004E", but it also seems to be a bare LED bulb, or a line of LED bulbs with different capabilities, and also a custom design service. The manual is a SAFETY TEST REPORT with no mention of DMX, or even a usable fixture.

We've already got generic OFL mappings for dimmers, and RGBW, so unless there's an actual fixture here with more capabilities (and consistent documentation), I don't think we need to keep these.