search

OpenLightingProject / open-fixture-library

A library and website for lighting technology's DMX fixture definition files.
https://open-fixture-library.org/
MIT License
194 stars 65 forks source link

Validation suggestion: unique URLs #4100

Open kengruven opened 4 months ago

kengruven commented 4 months ago

There are a lot of proposed fixtures I see where someone adds a bunch of URLs, all the same. (The most common is probably productPage and manual being the same.) I don't think it's ever correct for different URLs to be identical, so it would be nice if we could catch that before the JSON is submitted.

THEBOSS0369 commented 3 months ago

Then it would be nice to implement a validation step that would check if these URL's are different or not

Zaraka commented 2 months ago

The most common is probably productPage and manual being the same. Cameo QSpot 40 CW and WW have the same manual even though they are different fixtures with different specs, the manual lists both of them, DMX table is the same for both of them.

kengruven commented 2 months ago

The most common is probably productPage and manual being the same. Cameo QSpot 40 CW and WW have the same manual even though they are different fixtures with different specs, the manual lists both of them, DMX table is the same for both of them.

That's not what this is about, if I'm reading you right. What I'm saying is that it's (almost certainly) an error when one fixture has the same URL for its productPage and manual.

I'm not proposing to add a global uniqueness constraint for all manual links -- there's no need for that, and there'd be no way to enforce it, anyway.