search

OpenLightingProject / rdm-app

Code for the rdm.openlighting.org site
http://rdm.openlighting.org
17 stars 11 forks source link

A few more Robe PIDs #203

Closed peternewman closed 5 years ago

peternewman commented 6 years ago

I need to work out why this is failing and fix it first...

peternewman commented 6 years ago

@vanous would you mind reviewing these before I merge if you've got time?

nomis52 commented 6 years ago

LGTM

vanous commented 6 years ago

It looks good. Tomas says it's not complete, but i am not sure (when) he can export all the others... i am trying but cannot promise. Perhaps wait a few more days, then merge.

peternewman commented 6 years ago

Thanks @vanous .

You gave me a load of other PIDs here https://github.com/OpenLightingProject/rdm-app/pull/100#issuecomment-328076605 which I've formatted into a list in https://github.com/OpenLightingProject/rdm-app/issues/197 and will tick off as they get merged.

I was mostly hoping you could sanity check them and confirm any sub device targeting, or are they all root? And confirm things like DMC, although Googling suggests "During Movement Correction".