search

OpenLightingProject / rdm-app

Code for the rdm.openlighting.org site
http://rdm.openlighting.org
17 stars 11 forks source link

Port/Convert Manufacturer PID data to RDM Schema #280

Open Letrab opened 3 years ago

Letrab commented 3 years ago

Wouldn't it be nice to follow the upcoming RDM Schema for the manufacturer specific PIDs?https://github.com/ssilverman/rdm-schema

Or are there still things missing to map/port to this json format?

peternewman commented 3 years ago

Hi @Letrab ,

Sorry I missed this before, yes I'm sure we'll do something when it gets officially standardised, probably initially doing import and export and maybe/hopefully moving across to it in due course.

Its just been through a public review cycle a few months ago, so I'm sure they will be resolving those issues in due course: https://tsp.esta.org/tsp/documents/public_review_docs.php

I've not sat down and done a comparison recently, but Sean's stuff was originally based off a JSON version of the OLA schema so it shouldn't be too hard hopefully.

I'd imagine realistically we'd work on converting OLA to use it first, as there is likely to be more benefit there with dynamic UI elements there, whereas as long as this site can read and write them that's probably sufficient.

If you fancy having a little bit of a go at it, then any pull requests would be very welcome!