search

OpenLightingProject / rdm-app

Code for the rdm.openlighting.org site
http://rdm.openlighting.org
17 stars 11 forks source link

Manufacturer updates #287

Closed peternewman closed 3 years ago

FloEdelmann commented 3 years ago

@peternewman Is there any chance to get this merged soon?

We have manufacturer "Fiilex" in the Open Fixture Library (https://open-fixture-library.org/fiilex), which has RDM ID 24868/0x6124. It is also listed here: https://tsp.esta.org/tsp/working_groups/CP/mfctrIDs.php

But it is not included in the RDM app: http://rdm.openlighting.org/manufacturer/display?manufacturer=24868

peternewman commented 3 years ago

@peternewman Is there any chance to get this merged soon?

It's merged now, although until #206 gets in (and they moved the goalposts when I was almost there), I don't have a particularly easy way to deploy it currently unfortunately. :cry:

We have manufacturer "Fiilex" in the Open Fixture Library (https://open-fixture-library.org/fiilex), which has RDM ID 24868/0x6124. It is also listed here: https://tsp.esta.org/tsp/working_groups/CP/mfctrIDs.php

But it is not included in the RDM app: http://rdm.openlighting.org/manufacturer/display?manufacturer=24868

I think I could manually insert this manufacturer if that helps? Are they the only one you're missing currently?

FloEdelmann commented 3 years ago

Yes, that's the only missing manufacturer so far. If adding manually is possible, that would help a lot. Then we have one less failing link 😅

peternewman commented 3 years ago

I think that's there now @FloEdelmann . After I changed the URL from blank to null and flushed the cache.

Do you want to check if it's sorted your issue?

FloEdelmann commented 3 years ago

It did, thank you! :blush: