Open HakanL opened 9 years ago
How do we edit the makefile for building on 1.8.8?
Hi @stoneater ,
How does it fail, what error message(s) do you get?
This (unmerged) commit, fixes a warning, but that's unlikely to be making your build fail: https://github.com/OpenLightingProject/rgbmixer/pull/3/commits/a8ec5b1257fa6a98acc348d1dc9db523c55b6373
So unfortunately it may be no-one has fixed the issue yet.
I have the build environment, but running make doesn't find Arduino.h, likely because it resides in a different directory from the rather ancient version that rgbmixer was compiled on. I change the INSTALL_DIR to $(HOME)/arduino-1.8.8/hardware/ and it then can not find avr-g++ because it has moved. Unfortunately this puts us in a bind, since it uses CXX and INSTALL_DIR alternatively, if I change INSTALL_DIR to find Arduino.h then make can not find avr-g++, and if I change CXX to find avr-g++, then make can not find Arduino.h again. I would think that making a symbolic link to copy Arduino.h or avr-g++ might work, but that updating the Makefile to match current structure of arduino-1.8.8 would be the better way to go.
On further review, perhaps instead of a Makefile, can this be converted into something that can be used from the IDE, or am I missing something there too? I think I have gotten close, but now I need to set which variant I am compiling for. I was able to add -I $(INSTALL_DIR)/arduino/avr/cores/arduino/ to the ALL_CXXFLAGS to get a step further up the chain until I error, so progress!
Hi @stoneater
Would you like to give this a go, it compile for me against 1.8.2: https://github.com/OpenLightingProject/rgbmixer/pull/6
I've not tried the resulting hex file though.
I'm not across the reason it was written to use make rather than the Arduino IDE initially, I guess personal preference by @nomis52 or limitations in the old version of the IDE on Mac.
To help this/when it's fixed, we should add Travis Continuous Integration to the repo with Platform IO: http://platformio.org