search

OpenLightingProject / rp2040-dmxsun

RP2040-based USB DMX dongle with integrated web server
GNU General Public License v3.0
95 stars 16 forks source link

Fix a jsoncpp submodule typo #66

Closed peternewman closed 1 year ago

peternewman commented 1 year ago

Thanks for finding, this is indeed a funny one. I'm on mobile right now but on line 19 of the .gitmodules (submodule name), the typo is still there. Can you rename that as well and check if anything breaks? Thanks! Apart from that, good to merge

Dammit, I fixed that originally in https://github.com/OpenLightingProject/rp2040-dmxsun/pull/66/commits/11916fbbcf848c8db09a5c3be8436c18340efb12 but it failed to update the folder names themselves and failed, so I then did it properly on the CLI and it seems it's missed that now!

Now fixed anyway...

kripton commented 1 year ago

Indeed, changing stuff around submodules can be tedious and confusing. Nevertheless, nice catch, thanks for the PR!