search

OpenLoco / openloco-docker-build

Docker images for OpenLoco
0 stars 1 forks source link

Missing a backslash in Dockerfile? #13

Closed DanBodell closed 1 month ago

DanBodell commented 1 month ago

When I try and build the docker image from source, I get the compiler yelling at me that it doesn't know what clang is. Adding a space and a backslash at the end of line 6 solved it for me, wasn't sure if that was universal or not. Figured I'd check before doing a pull request

AaronVanGeffen commented 1 month ago

You're totally right. The Dockerfile in the root of the repository is actually not the one we use for CI builds today. We use three Docker CI images, and the current ones are in the folder with the highest number, which is currently version 7.

I think we should probably delete the old, very dated Dockerfile at the root of the repository to prevent confusion. @janisozaur, what do you think?

DanBodell commented 1 month ago

I believe a quick little Readme.md file in the repo to explain how things are set up would go a long ways for people like me blindly grasping at making things work. Pretty much what you said Aaron would be enough to not blindly wander into depreciated docker files like me XD

janisozaur commented 1 month ago

Yes, this should get removed

AaronVanGeffen commented 1 month ago

Removed in f13ee17924f4cf5cc119549e028935597bca1dd4.