search

OpenLogicProject / OpenLogic

An open-source, customizable intermediate logic textbook
http://openlogicproject.org/
Creative Commons Attribution 4.0 International
1.07k stars 241 forks source link

Remove irrelevant objects from Theorem 7.6 #244

Closed marcelolynch closed 4 years ago

marcelolynch commented 4 years ago

Fixes a small typo in a footnote defining "vector" notation for parameters in a formula

marcelolynch commented 4 years ago

Not sure if this merits a PR or if raising an issue is more appropriate.

marcelolynch commented 4 years ago

I also notice that this definition is sort of irrelevant? The formula $\phi$ and sets $\overline{c}$ are not used in the Theorem, and indeed there is an additional explanation for "parameters" a little bit later which doesn't use the notation. I would argue for removing everything after "for every set X" (including the footnote)

timbutton commented 4 years ago

I endorse the change - looking at the version I have on my machine, I didn't use vector notation there, and didn't have the footnote; I guess someone else added it? Or maybe I lost track of things.

rzach commented 4 years ago

Great thanks to both of you!

marcelolynch commented 4 years ago

It seems that the line was supposed to be commented (if you check line 17 before my last commit, it ends with % for). I tracked other uses of the "vector notation" and it is safe to delete it here (the notation is defined again and used in section 12.5).