OpenLogicProject / OpenLogic

An open-source, customizable intermediate logic textbook
http://openlogicproject.org/
Creative Commons Attribution 4.0 International
1.06k stars 240 forks source link

Multiple incompatible definitions for "total order" #334

Closed gabelthompson closed 1 year ago

gabelthompson commented 1 year ago

Definition 2.16, definition 2.24, and the footnote of section 5.6 each define "total order" in different, and incompatible, ways. Several section 2.5 propositions, and one example, are also affected by the incompatible definitions. It appears that definition 2.16 is the intended (and conventional) definition of a total order. Is this correct?

If so, I can send a pull request with suggested changes to resolve the issue.

Update 6/7/23: I went ahead and sent a pull request with suggested changes to resolve this issue.

rzach commented 1 year ago

Thanks!