search

OpenLogicProject / OpenLogic

An open-source, customizable intermediate logic textbook
http://openlogicproject.org/
Creative Commons Attribution 4.0 International
1.02k stars 234 forks source link

Frege #342

Closed rikiheck closed 7 months ago

rikiheck commented 9 months ago

I was just looking through the book and stumbled across the Appendix on Basic Law V in 61.6 of the full build. This is not accurate. Frege does not define extensions of concepts at all but rather the 'value-ranges' of functions. For the purposes of this book, it's entirely reasonable to abstract from this, but some kind of note should be added that this is what's being done. Alternatively, one could make the discussion more accurate. If you want to do that, I could have a go at re-writing the section. Cheers, Richard Kimberly Heck

rzach commented 9 months ago

This part is from @timbutton -- Tim, what do you think?

timbutton commented 9 months ago

If Heck wants to write a better version, great! (Yup: I wrote it in a hurry; it’s inaccurate; I didn’t think it mattered too much, but I’d rather it were more accurate!)

— Tim Button (he) Head of Department, Philosophy, UCL http://nottub.com/

From: Richard Zach @.> Sent: Monday, October 9, 2023 5:53 PM To: OpenLogicProject/OpenLogic @.> Cc: Button, Tim @.>; Mention @.> Subject: Re: [OpenLogicProject/OpenLogic] Frege (Issue #342)

⚠ Caution: External sender

This part is from @timbuttonhttps://github.com/timbutton -- Tim, what do you think?

— Reply to this email directly, view it on GitHubhttps://github.com/OpenLogicProject/OpenLogic/issues/342#issuecomment-1753350038, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM5CQB2C7D2Y5VAUIJTUHCDX6QTWDAVCNFSM6AAAAAA5ZCKKTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTGM2TAMBTHA. You are receiving this because you were mentioned.Message ID: @.***>

rikiheck commented 9 months ago

I think it's adequate to add a clarifying footnote, and maybe a reference to an explanation elsewhere. You probably don't want to get into these particular weeds right here. Patch attached. Feel free to remove the citation if you think that's overkill.

0001-Add-note-on-value-ranges.patch.txt

rzach commented 7 months ago

Thanks again; sorry this took so long.