OpenMAVN / PM

OpenMAVN project management
MIT License
0 stars 3 forks source link

Select Location for Offers/Map when location services are denied #124

Open MarlonMaercz opened 4 years ago

MarlonMaercz commented 4 years ago

As a customer who has denied the mobile app's location services, I want to be able to select a location of my interest from the Offers page, in order to filter out vouchers to those available to the location of my choosing.

AC's

  1. Selecting location manually GIVEN I am a customer logged into the mobile app AND I have denied location services #27 WHEN I open the Offers page THEN I can see: a. "Select location" statement b. List of countries that have some vouchers attached - sorted Asc c. Search feature (I start typing, the list proposes just the options matching to the search request)

  2. Displaying vouchers according to selected location GIVEN I am on the Offers page WHEN I select a location manually (N1) THEN the list of locations is closed and the list of Offers appears onscreen - in accordance with the selected location

  3. Changing location manually GIVEN I am a customer logged into the mobile app AND I am on the Offers page AND I have defined location of my interest manually (N1, N2) WHEN I click on the < Pin icon > at the top of the screen THEN I can change the selection of the location - same way as in N1 above (the screen with location options opens), plus the screen indicates the currently selected location

  4. Applying manually selected location on the map GIVEN I am on the Offers page AND I have defined location of my interest manually (N1, N2) WHEN I click on the location button on the top right of the offers page #63 THEN a map is opened within the mobile app AND the map is centered on the selected location AND I can see on the map all offers available for this location

Design mockup (please count the description above): https://invis.io/9EXPZZN8RW3

pddimitrova commented 4 years ago

@MarlonMaercz For AC N1, where is this search located? Where do we fetch this list of places from? Our own BE? Maps API? Keep in mind searching for location has a different free quota for Google maps which, in my previous experiences, is used up fairly quickly. I can find more details if needed.

AC1/ACs It seems there is a UI component that is not described here, I am referring the part "WHEN I click on the". What is this component, where is it placed?

ElenaBelyavskaya commented 4 years ago

@pddimitrova I have adjusted the desc - it appeared the text taken into '<>' was not displayed :) So "WHEN I click on the" is about the Pin icon that should be introduced for the purpose of selecting the location manually.

AC1: I propose to place the Pin icon at the top of the Offers page (if we don't have a design mockup soon)

It would be efficient to use the list of locations attached to the map (and I believe we don't yet have the list of locations in backend). But if it's not free, we need to investigate the options.

starkmsu commented 4 years ago

@MarlonMaercz , @ElenaBelyavskaya , do we need to show only countries where partner locations with active voucher campaigns are present? Or the whole list of possible countries that we presented for residence selection?

ElenaBelyavskaya commented 4 years ago

@starkmsu when grooming we decided to show the list of countries where there are some vouchers. Are you ok with it from the tech/development perspective?

starkmsu commented 4 years ago

@MarlonMaercz , @ElenaBelyavskaya , it would be much easier to show the list of countries where existing partners have some locations. Can we use that approach, without additional filtering for existing active voucher campaigns?

ElenaBelyavskaya commented 4 years ago

@starkmsu from the result perspective, this should be the same (or almost the same), because creating partners (with location) is aimed at issuing vouchers; so I don't mind. @MarlonMaercz any objections?

pddimitrova commented 4 years ago

@ElenaBelyavskaya I think I can find a nice map icon that we can use for the map from now on and we can use the current pin icon to select location

ElenaBelyavskaya commented 4 years ago

@pddimitrova @MarlonMaercz I have verified that the description complies with what we have agreed on during the grooming call today (just made a couple really minor improvements)

pddimitrova commented 4 years ago

@MarlonMaercz @ElenaBelyavskaya I have a suggestion concerning a problem. When a user selects a country, we cannot center it directly on the map, because there is no such method in Google maps and we do not have enough information to do it manually.

However, I have the following suggestion. When the user selects a country, we fetch the campaigns for the selected country. I suggest when we add the campaigns to the map as markers, to center the areas= that contains the markers so that all of the markers for the country are visible.

ElenaBelyavskaya commented 4 years ago

@pddimitrova that's a great proposal actually-this way we would definitely show offers on the map (if there is at least one for the country), less chances for an empty map.

I am failing to test the selection of countries - I have denied to detect location (and geo location is Off), but the app still shows offers

pddimitrova commented 4 years ago

@ElenaBelyavskaya There is no build containing this functionality yet. I'll create one now, but we should be mindful of our CI build minutes, we're close to running out

pddimitrova commented 4 years ago

@ElenaBelyavskaya Please download build 0.1.0+2 which does include this functionality

MarlonMaercz commented 4 years ago

@pddimitrova 1a. Pass 1b. Fail: No list is presented 1c. Pass*: suggestion is shown. However, the suggestion must be clicked. It is not recognized if I fully type the country and press enter or done. Will raise a separate ticket for this.

  1. Pass
  2. Pass* : Does not work when changing location from map and going back to offers screen. Raise a new story for this.
  3. Pass CC @ElenaBelyavskaya