Move Dynamic Options - Githubissues

OpenMDAO / Aviary

NASA's aircraft analysis, design, and optimization tool

https://openmdao.github.io/Aviary/

Other

110 stars 51 forks source link

Move Dynamic Options #268

Closed xjjiang closed 1 month ago

xjjiang commented 2 months ago

Summary

renamed CruiseAero to TabularCruiseAero in table_based.py;
renamed LowSpeedAero to TabularLowSpeedAero in table_based.py;
replaced include_strut by Aircraft.Wing.HAS_STRUT;
renamed training_data to connect_training_data.

Related Issues

Resolves #

Backwards incompatibilities

None

New Dependencies

None

xjjiang commented 2 months ago

There are a few more options that are file paths. For example:

aero_data
free_aero_data
flaps_aero_data
ground_aero_data

I am not sure if we need to convert them to Aviary variables.

Kenneth-T-Moore commented 2 months ago

You should build the docs. It looks like "user_guide/external_aero" is the notebook that is failing. My guess is the change in the name for the tabular aero objects.

Best way to debug these is to use jupyter-notebook, and run all of the cells. (Just remember to delete the output cells before committing.)

xjjiang commented 2 months ago

Please review again.