search

OpenMDAO / Aviary

NASA's aircraft analysis, design, and optimization tool
https://openmdao.github.io/Aviary/
Other
134 stars 59 forks source link

Refactor drag calculation in internal aero so that the CD is computed after the subsonic and supersonic scaling factors have been applied. #279

Closed Kenneth-T-Moore closed 4 months ago

Kenneth-T-Moore commented 4 months ago

Summary

The motivation for this was the confusion this created while debugging the drag coefficients compared to FLOPS. Our values were prior to applying the final scale factors, so we weren't matching until we realized what was happening.

For aviary internal aerodynamics computed with the height-energy method:

  1. Split SimpleDrag component into SimpleCD and SimpleDrag. Post-scaled drag is now an output of SimpleCD instead of being an internal calculation unavailable to openmdao.
  2. Rename "drag_coefficient" to "CD" for simplicity.
  3. Made the promotion level for 'CD' equivalent for our 3 builders.

Related Issues

Backwards incompatibilities

None

New Dependencies

None