search

OpenMDAO / Aviary

NASA's aircraft analysis, design, and optimization tool
https://openmdao.github.io/Aviary/
Other
107 stars 51 forks source link

Make reasonable defaults throughout Aviary #291

Open johnjasa opened 1 month ago

johnjasa commented 1 month ago

Desired capability or behavior.

Make reasonable defaults for Aviary throughout the code, especially if the options are subtly different. Whichever converges more reliably should be the default, after that then the one with the fewest number of inputs makes sense, or something where you can measure the physical properties of the aircraft. Do this throughout the code and for most all levels.

This issue is broad on purpose; please consider this for all parts of code you're developing

Is your feature request related to a problem? Please describe.

No response

Associated Bug Report

No response

jkirk5 commented 1 week ago

This is a good opportunity to break from legacy code defaults. When converting a file from FLOPS or GASP, we can use the legacy code's defaults whenever there is a difference between Aviary defaults and the legacy code defaults. Basically add those variables to the .csv so they overwrite the Aviary defaults.

For Aviary, a decision must be made on what the purpose of defaults is - is it to provide "reasonable" values so they are not required? If so, what aircraft type/class should these defaults target? Should "required" inputs still have a default, or should they default to 0 or None to force users to select a value?