search

OpenMDAO / Aviary

NASA's aircraft analysis, design, and optimization tool
https://openmdao.github.io/Aviary/
Other
106 stars 51 forks source link

Electroprop #332

Open jkirk5 opened 2 weeks ago

jkirk5 commented 2 weeks ago

Summary

Formally brings in the motor model as a core Aviary subsystem, and overhauls the Turboprop component to be able to accept either a motor model or a turboshaft.

Numerous fixes to ensure that connections within the Turboprop component are working as intended - previously many connections were not properly getting made to the rest of Aviary

Backwards incompatibilities

None

New Dependencies

None

Kenneth-T-Moore commented 1 week ago

There's a lot of commented out stuff in this PR -- variables, code, tests -- some of it is newly introduced, but some of it is pre-existing. Can you explain this in a little more detail?

jkirk5 commented 1 week ago

There's a lot of commented out stuff in this PR -- variables, code, tests -- some of it is newly introduced, but some of it is pre-existing. Can you explain this in a little more detail?

I did a lot of prototyping in this PR, so I'll do a review pass to remove no longer necessary code. Some of the commented out code might stay as we may want to implement those ideas in the future, but I can add some additional context for those!