search

OpenMDAO / Aviary

NASA's aircraft analysis, design, and optimization tool
https://openmdao.github.io/Aviary/
Other
106 stars 51 forks source link

Improve reading vector variables from csv #336

Closed jkirk5 closed 1 week ago

jkirk5 commented 2 weeks ago

Summary

Added some protections when reading a variable from .csv that is supposed to be a vector (e.g. engine wing locations). Attempts to account for the fact that sometimes a vector means each index goes to an engine, but in a single-engine-type aircraft sometimes the whole vector is supposed to pair with the engine

jkirk5 commented 1 week ago

Does it make sense to add a test for these multidimensional array cases? Or are those tests not relevant yet?

Yes, it would make sense to have a test for this - we currently don't have an aircraft model in the repo w/ 2 or more engines per wing without running into other issues (multiple engine types and turboprops currently not supported from csv level). So I'll say future work (to either create a new test case or add these features to level 1 and change an existing test case to read from csv instead of L2 interface)