search

OpenMDAO / Aviary

NASA's aircraft analysis, design, and optimization tool
https://openmdao.github.io/Aviary/
Other
106 stars 51 forks source link

Simplify provide_surface_area option #366

Open jkirk5 opened 5 days ago

jkirk5 commented 5 days ago

Desired capability or behavior.

The option Aircraft.Fuselage.PROVIDE_SURFACE_AREA is now obsolete with the addition of overrides. It should be removed and override functionality implemented

Erik: There are currently four variables related to fuselage wetted area:

Aircraft.Fuselage.PROVIDE_SURFACE_AREA
Aircraft.Fuselage.WETTED_AREA
Aircraft.Fuselage.WETTED_AREA_FACTOR
Aircraft.Fuselage.WETTED_AREA_SCALER

In GASP geometry calculations, if PROVIDE_SURFACE_AREA is True, WETTED_AREA_FACTOR is used to override the actual fuselage wetted area. Otherwise, wetted area is calculated and scaled by WETTED_AREA_FACTOR. In FLOPS geometry, if WETTED_AREA is input it is used to override the calculated fuselage wetted area. Otherwise, wetted area is calculated and scaled by WETTED_AREA_SCALER.

The GASP calculations should be modified to use the same process as the FLOPS calcs. PROVIDE_SURFACE_AREA and WETTED_AREA_FACTOR then should be eliminated.

Ken: Some thoughts on this:

I agree with Erik that we should (wherever we can) make the interface between the 2 sides similar. We can use WETTED_AREA_SCALER on the flops side, so would be ideal to use it on the gasp side too.

For PROVIDE_SURFACE_AREA to work, we need overrides to be supported on the gasp side. I am not confident that they are implemented there, so getting that to work would be a pre-requisite for this issue.

Is your feature request related to a problem? Please describe.

No response

Associated Bug Report

No response