fixed load_case logic to correctly handle negative-duration phases

OpenMDAO / dymos

Open Source Optimization of Dynamic Multidisciplinary Systems

Apache License 2.0

202 stars 65 forks source link

fixed load_case logic to correctly handle negative-duration phases #1007

Closed robfalck closed 10 months ago

robfalck commented 10 months ago

Summary

Phase.load_case did not handle negative-duration cases correctly.
The use of np.unique in the method sorts the previous phase time values, which caused the time values and the corresponding unique indices to be reversed.
Tests that were previously skipped due to this issue have been enabled.

Related Issues

Resolves #1006

Backwards incompatibilities

None

New Dependencies

None

coveralls commented 10 months ago

coverage: 92.776% (+0.09%) from 92.686% when pulling 4a9bb98633049cb2a0f88cfe9fe4de13deafd3dd on robfalck:load_case_negative_duration into 7fe881998f11545e048ab12ea0e517ac703a9e21 on OpenMDAO:master.