search

OpenMDAO / dymos

Open Source Optimization of Dynamic Multidisciplinary Systems
Apache License 2.0
195 stars 64 forks source link

Added inline directive to notebooks that use matplotlib #1054

Closed swryan closed 3 months ago

swryan commented 4 months ago

Summary

Per matplotlib-inline:

Note that in current versions of JupyterLab and Jupyter Notebook, the explicit use of the %matplotlib inline directive is not needed anymore...

However this seems to have stopped working between the Dymos 1.9.1 and 1.10.0 releases. I was unable to determine what changed that caused this or how to make it work again, so I just reintroduced the directive to all applicable notebooks.

In the process, I also removed the pin from jupyter-book exposing a handful of invalid xref links (pointing to .md files instead of .ipynb) which have been fixed.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

coveralls commented 4 months ago

Coverage Status

coverage: 92.798% (-0.2%) from 93.017% when pulling ff223b4cdedf09bc687c2295e2223b12f1c4e0c2 on swryan:1049_plots into 19ba7a36bc4dc8abec6017ef1f8abbc20fe7642e on OpenMDAO:master.