Unify controls and polynomial controls

johnjasa commented 1 month ago

Summary

This PR simplifies a lot of the controls-based logic to remove the separation between polynomial and full controls. This doesn't add or remove any capability but it simplifies a lot of code under the hood. We'll be able to more easily add other control types (b-splines? others?) if desired with these changes. All tests are passing locally for me but I'll address any failures on CI as well.

Questions:

I've called regular controls "full" controls within the code. Is this a good name? What name should we use instead? To be clear, I've introduce a control_type option that has full or polynomial as possibilities.
Are there other implications of the changes in this PR that I need to address?

Backwards incompatibilities

Introduced a deprecation warning for add_polynomial_control; the method still works in this version but can be removed later on.

New Dependencies

None

coveralls commented 1 month ago

coverage: 92.803% (+0.5%) from 92.35% when pulling e0c8a304cb0564c3e693fa9becea0d2991adb47e on johnjasa:rework_controls into 6ee8eeceed4ff276af3be4594dda50ad3e7110ef on OpenMDAO:master.

coveralls commented 1 month ago

coverage: 92.707% (+0.4%) from 92.35% when pulling df9e551e1ba2371a10e407f1a1bd2a8915221342 on johnjasa:rework_controls into 6ee8eeceed4ff276af3be4594dda50ad3e7110ef on OpenMDAO:master.

review-notebook-app[bot] commented 3 weeks ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

coveralls commented 3 weeks ago

coverage: 92.574% (+0.2%) from 92.35% when pulling a1854f5cfe67665de45f7ff5349a7d872a73b778 on johnjasa:rework_controls into 6ee8eeceed4ff276af3be4594dda50ad3e7110ef on OpenMDAO:master.

OpenMDAO / dymos