OpenMDAO / dymos

Open Source Optimization of Dynamic Multidisciplinary Systems
Apache License 2.0
208 stars 66 forks source link

OpenMDAO should complain when a derivatives check uses the same method as the derivative calculation #603

Closed robfalck closed 3 years ago

robfalck commented 3 years ago

Summary of Issue

OpenMDAO can check partials with the same method used to compute them (e.g. 'cs' and 'cs' or 'fd/forward' and 'fd/forward'). This should not be allowed.

Issue Type

Description

The check_partials functionality allows a user to check the accuracy of components that use cs by using cs. This will result in no difference and is obviously not what we want. This sort of behavior should probably result in an exception, since an ignored warning here can result in the failure of a model to work correctly.

OpenMDAO should allow forward finite difference to be checked with other forms of finite difference.

check_totals used with approx_totals is also subject to the same issue.

Example

N/A

Environment

N/A

robfalck commented 3 years ago

Wrong repo 👎