search

OpenMDAO / mphys

Multiphysics with OpenMDAO
Other
48 stars 31 forks source link

shape_by_conn is broken for parallel to serial connections #56

Closed anilyil closed 2 years ago

anilyil commented 3 years ago

I merged the PR that removed all of the src_indices from the wrappers and replaced it with shape by conn (#51). However, I did not realize a certain type of connections would be broken this way. I will now work towards resolving this issue in the short term, but users should keep this in mind. Currently, the master branch is broken for parallel models where a distributed component's output is connected to an input of a serial component where the input is shaped by connection. One example of this type of connection is in the adflow wrapper. The volume mesh and state connection to the adflow functionals group is broken for example.

To avoid this issue, checkout the latest tagged version. I will post updates here once I fix it in the short term, and another update when the shape by connection is fixed on the openmdao side.

anilyil commented 3 years ago

So master works now because I merged #57. The issue was only with adflow. We will need to keep this in mind after the shape_by_conn behavior is updated, so I will keep this issue open.

kejacobson commented 2 years ago

shape_by_conn and distributed variables in OpenMDAO changed by POEM 46.