search

OpenMDAO / pyCycle

Thermodynamic cycle modeling library, built on top of OpenMDAO
Other
77 stars 53 forks source link

Fix Turbine and Combustor thermo_data #15

Closed askprash closed 4 years ago

askprash commented 4 years ago

Combustor and Turbine bleeds were not being given the right thermo_data. Fixed by passing it when instantiating the bleeds within the turbine.

JustinSGray commented 4 years ago

Thanks for these updates. Was there a bug you noticed that led you to make these changes? Some model that wasn't working the way you expected?

askprash commented 4 years ago

Hey @JustinSGray, I noticed this as I was trying to add humidity capability to pyCycle calcualtions. I wanted to modify the janaf.py with a custom thermo. That's when I noticed this bug. The way it is setup right now the bleeds' thermo was defaulting to janaf.py even if the parent turbine had a different thermo specified. The combustor, is being made more robust by the other PR.

Question: should I modify this PR in anyway? A little new to submitting PRs.

JustinSGray commented 4 years ago

got it. That makes sense. I think your PR is fine. I'll merge it