search

OpenMDAO / pyCycle

Thermodynamic cycle modeling library, built on top of OpenMDAO
Other
75 stars 51 forks source link

Change breaks existing code #48

Closed Suficio closed 2 years ago

Suficio commented 2 years ago

The change of the following line in https://github.com/OpenMDAO/pyCycle/commit/3489800441a2ccea922fb4b7d3118d7f9a6a9e0f breaks current example and my own code. Changing 'val' back to 'value' resolves the issue.

https://github.com/OpenMDAO/pyCycle/blob/3489800441a2ccea922fb4b7d3118d7f9a6a9e0f/pycycle/thermo/unit_comps.py#L26

Fixed in https://github.com/OpenMDAO/pyCycle/pull/47

Suficio commented 2 years ago

I realize this is due to running an incompatible version of OpenMDAO.