Closed anhvt2 closed 4 years ago
I ran your commit and the baseline run file in the repo and got the same converged value for fan diameter. There have been a few minor tweaks to pyCycle and OpenMDAO itself since the publication of the paper and that seems to have affected the converged values a tiny bit.
at the level of accuracy of this analysis 100.6 vs 100.1 isn't a meaningful change overall. Some of the numerical details in pyCycle mean that we're taking the inverse of some VERY VERY poorly conditioned matrices and that causes a small amount of numerical noise. That, combined with tiny changes to algorithms and small refactors of the code will add up to tiny drifts like that.
Your run is matching what Im seeing, and our current code base is passing all of our regression tests. So you're good.
If you really want it to match the paper exactly, you should roll back to the 1.0 version of pycycle. You'll have to roll back to a version of OpenMDAO that works with that as well. 2.10 should do it.
Dear pyCycle developers,
I'm trying to reproduce the baseline described in your paper. The script is as below. I can reproduce
CRZ.perf.TSFC = 0.44078732
but notTOC.fan_dia.FanDia = 100.61981154233395
(in the paper it is 100.1907). Did I miss something or set the values incorrectly? Please let me know.Many thanks!