OpenMOOC / moocng

MOOC Engine
Apache License 2.0
88 stars 43 forks source link

Adding course name to subject in massive mails #11

Open versae opened 11 years ago

versae commented 11 years ago

Since there is no custom emails for courses, should be nice if by default the course name is added to the subject of the email, so students enrolled in more than one course can know what course the email comes from.

I changed this two lines in teacheradmin/tasks.py

if len(recipients) > 0:
    subject = u"[%s] %s" % (email.course.name, email.subject)
    send_mass_mail_wrapper(subject, email.message, recipients, html_content=True)
ablanco commented 11 years ago

The problem comes with courses with long names, it will result in a too long subject.

versae commented 11 years ago

Maybe in the body? I'd say that a solution could be add a couple of new fields in the course model, one for the email for announcements, and another one for the email to communicate to the teachers.

ablanco commented 11 years ago

We can do something similar to what coursera does. We can write the name of the course in the from address, something like:

from: Name of the Course <info@openmooc.org>

And add the course name at the top of the mail body too.

versae commented 11 years ago

That'd be cool.