search

OpenMOOC / moocng

MOOC Engine
Apache License 2.0
88 stars 43 forks source link

Delete peer review submissions and reviews when a knoledge quantum is removed #21

Closed fid-jose closed 11 years ago

fid-jose commented 11 years ago

Implemented PrivateKnowledgeQuantumResource.obj_delete to remove all peer review submissions and reviews when a knowledge quantum has a peer review assignment.

ablanco commented 11 years ago

@fid-jose I initially merged this, but I have finally removed it from the repository.

Following the same criteria that the one used with regular questions, the data in the mongodb is not removed when the django models are deleted. In the mongo we store the students' input, and as a policy we don't delete that automatically.

Thanks for the contribution anyway.

fid-jose commented 11 years ago

If that's the case, should PrivatePeerReviewAssignmentResource.obj_delete be modified as well? (and the warning before removing a Peer Review Assignment in the teacher interface modified/removed)?

ablanco commented 11 years ago

@fid-jose Yes, I think that's the best approach. I'll remove them now.