search

OpenMOOC / moocng

MOOC Engine
Apache License 2.0
88 stars 43 forks source link

feature no-video quantums #23

Closed jespino closed 11 years ago

jespino commented 11 years ago

De esto falta los scripts de migración, por ahora cierro el pull request.

jespino commented 11 years ago

Now included the south migration scripts (model and data)

ablanco commented 11 years ago

I'm getting a 500 error accessing the classroom:

ImportError('No module named requests',)

I guess requests 1.2.0 is a missing dependence.

ablanco commented 11 years ago

Some files don't pass PEP8 validation. In this project we follow PEP8 directives but for the "line too long" restriction.

ablanco commented 11 years ago

These are the preliminary errors I found in the initial testing of the classroom view and teacher admin:

  1. Uncaught TypeError: Cannot call method 'getAttribute' of undefined froogaloop.min.js:2
    • This happens sometimes, even where there are no vimeo videos in the course.
    • The libraries shouldn't be loaded if there aren't nuggets that use them. In a course with only youtube videos, the vimeo library shouldn't be loaded and viceversa.
  2. Uncaught ReferenceError: gettext is not defined routes.js:81
    • This happens when I try to access to the root of the classroom view, not directly to a nugget. At least if the module is empty.
  3. Moving to the question automatically when the video finishes no longer works, at least with YouTube and Vimeo.
  4. I can't navigate to a question nor a peer review.
    • Not with the next button nor directly with url.
    • There are a lot of uncontrolled undefined errors and more problems.
  5. YouTube should be the default option when creating a nugget.

@jespino After I merge moocng master into the no-video branch I couldn't use the classroom view (I haven't tried without merging master). Could you fix these problems and send the pull request again? Thanks.

jespino commented 11 years ago

Of course :)