OpenMP-Validation-and-Verification / OpenMP_VV

OpenMP Offloading Validation & Verification Suite; Official repository. We have migrated from bitbucket!! For documentation, results, publication and presentations, please check out our website ->
https://crpl.cis.udel.edu/ompvvsollve/
Other
54 stars 19 forks source link

test_target_update_mapper_from_discontiguous.F90 mapper not strided #643

Open bcornille opened 1 year ago

bcornille commented 1 year ago

Describe the bug The Fortran version of this test has mapper

        !$omp declare mapper(newvec :: v)&
        !$omp& map(v, v%data(1:v%len))

whereas the C version has mapper

#pragma omp declare mapper(newvec_t v) map(v, v.data[0:v.len:2])

The stride is not present in the Fortran test so does not appear to be testing the same functionality. It would probably be prudent to adjust the test to ensure the intermediate elements are not updated after being set in the target region.

Test that it applies to test_target_update_mapper_from_discontiguous.F90

Expected behavior I expect the Fortran version of this test mapper to have mapper

        !$omp declare mapper(newvec :: v)&
        !$omp& map(v, v%data(1:v%len:2))
spophale commented 1 year ago

The map cannot be stripped. We recently changed our C tests to make the "update" update discontiguous elements of an array.