Adding more tests with teams loop construct

[lthakur007]

Please review..

[seyonglee]

Add brief descriptions to the beginning of each test using the format used in other tests.

[seyonglee]

GCC 13.1.1 on the Summit system fails on test_target_teams_loop_allocate.c with the following error messages: (the other tests pass with GCC 13.1.1.)

25:17: error: 'local' specified in 'allocate' clause but not in an explicit privatization clause

However, this seems to be a compiler bug.

[tob2]

GCC 13.1.1 on the Summit system fails on test_target_teams_loop_allocate.c with the following error messages: (the other tests pass with GCC 13.1.1.)

25:17: error: 'local' specified in 'allocate' clause but not in an explicit privatization clause

However, this seems to be a compiler bug.

Actually, it is a code bug:

#pragma omp target teams loop ... allocate(omp_default_mem_alloc: local) private(local)

Namely:

• the private clause is accepted by all of them: loop, teams and target, but "Clauses on Combined and Composite Constructs" section states: "The effect of the private clause is as if it is applied only to the innermost leaf construct that permits it." — Thus, private applies to only to loop.
• the allocate clause is accepted only by teams and target but not by loop. The "Clauses on Combined and Composite Constructs" section states: "The effect of the allocate clause is as if it is applied to all leaf constructs that permit the clause and to which a data-sharing attribute clause that may create a private copy of the same list item is applied." → In principle, teams and target would qualify, but neither of them has a data-sharing attribute (as the 'private' is already consumed by 'loops')
• Additionally, the following is required — but not fulfilled for allocate: "Restrictions to clauses on combined and composite constructs are as follows:
  • A clause that appears on a combined or composite construct must apply to at least one of the leaf constructs per the rules defined in this section."

I have now filed a GCC issue, PR111042, to improve the message wording for C/C++ and to add an error check for Fortran (currently, it crashes for the F90 vanriant of the invalid directive).

[lthakur007]

Hi @seyonglee and @seyonglee , Could you please share your opinion on the comment made by @tob2 . Please advise if we should remove the test file or any modification would allow allocate() clause still applicable.

[lthakur007]

addressed review comments.. please approve...

[lthakur007]

Hi @seyonglee and @spophale , I have addressed the review comments. Please consider to scrutinize the fixes... Fixes are working fine on AMD platforms....

[spophale]

@lthakur007 , generally arrays are not the best data types to check if defaultmaps were correctly applied as they have an implicit data mapping of toform on target directive.

[spophale]

Add for all tests in main:

OMPVV_TEST_OFFLOADING;

This will ensure that the correct message is printed. Like "Test passed on device .."

[lthakur007]

Hi @seyonglee and @spophale , I have addressed review comments... please consider the fixes....

[spophale]

@lthakur007 please review our comments at your convenience.

[lthakur007]

Hi @fel-cab , I have committed the changes you suggested. Please consider the PR for further processing...