Adding Test Cases for Target Parallel Loop Construct

[jainprad]

Please Review the test cases.

[seyonglee]

[Results on Summit after fixing hostMin and hostMax errors]

• test_target_parallel_loop_collapse.c
  • GCC 13.1.1: C test passed.
  • XL 16.1.1-10: C test passed.
  • NVHPC 22.11: C test passed.
  • LLVM 17.0.0: Condition test_target_parallel_loop_collapse() failed
• test_target_parallel_loop_reduction.c
  • GCC 13.1.1: C test passed.
  • XL 16.1.1-10: C test passed.
  • NVHPC 22.11: C test failed: Condition result != hostMin failed; Condition result != hostMax failed
  • LLVM 17.0.0: Condition result != hostMin failed; Condition result != hostMax failed; Condition total != sum_host failed

LLVM V17 and NVHC V22.11 fail on the reduction tests; can these fails be related to using fmin() and fmax() functions, where argument types are double, for integer variables?

[jainprad]

[Results on Summit after fixing hostMin and hostMax errors]

• test_target_parallel_loop_collapse.c

  • GCC 13.1.1: C test passed.
  • XL 16.1.1-10: C test passed.
  • NVHPC 22.11: C test passed.
  • LLVM 17.0.0: Condition test_target_parallel_loop_collapse() failed

• test_target_parallel_loop_reduction.c

  • GCC 13.1.1: C test passed.
  • XL 16.1.1-10: C test passed.
  • NVHPC 22.11: C test failed: Condition result != hostMin failed; Condition result != hostMax failed
  • LLVM 17.0.0: Condition result != hostMin failed; Condition result != hostMax failed; Condition total != sum_host failed

LLVM V17 and NVHC V22.11 fail on the reduction tests; can these fails be related to using fmin() and fmax() functions, where argument types are double, for integer variables?

Thanks Seyonglee for Review. in C, math.h library functions fmin() and fmax() always returns floating point values either passing integer or floating point as arguments. Here I am casting return value to the result integer variable and comparing result with hostMin/hostMax(integer) that should be correct and pass. But to make this tests according to definition of fmin() and fmax, I have declared all the arrays, result, hostMin and hostMax as double variable. I will upload the updated code for review and execution on your setup. Thanks.

[jainprad]

Hi @spophale , Please review.

[seyonglee]

[Summit Results after @jainprad's update]

• test_target_parallel_loop_collapse.c
  • GCC 13.1.1: C test passed.
  • XL 16.1.1-10: C test passed.
  • NVHPC 22.11: C test passed.
  • LLVM 17.0.0: Condition test_target_parallel_loop_collapse() failed (The value of errors is 605999.)
• test_target_parallel_loop_reduction.c
  • GCC 13.1.1: C test passed.
  • XL 16.1.1-10: C test passed.
  • NVHPC 22.11: C test passed.
  • LLVM 17.0.0: Condition result != hostMin failed; Condition result != hostMax failed; Condition total != sum_host failed

After changing the variable types in the reduction test to double, the NVHPC-compiled version also passed while the LLVM-compiled version still failed. I don't see any other issue on these tests.