search

OpenMP-Validation-and-Verification / OpenMP_VV

OpenMP Offloading Validation & Verification Suite; Official repository. We have migrated from bitbucket!! For documentation, results, publication and presentations, please check out our website ->
https://crpl.cis.udel.edu/ompvvsollve/
Other
54 stars 19 forks source link

Flipped values for USM macro var, now default value is zero to indica… #788

Closed andrewkallai closed 9 months ago

andrewkallai commented 10 months ago

…te no USM present

fel-cab commented 10 months ago

@andrewkallai is going to add the tests that rely on the macro before we approve it.

andrewkallai commented 10 months ago

All C tests which rely on the macro have been reviewed.

fel-cab commented 10 months ago

@andrewkallai are you going to add, to this commit, the C tests that rely this macro and have to be changed?

andrewkallai commented 10 months ago

No changes are needed so no tests need to be added. Note: referenced tests are from this command-> grep -r "SHARED_ENV" tests/ --exclude=.F90

spophale commented 9 months ago

@andrewkallai , since the behavior is reversed, will the tests not need updating as well ?

andrewkallai commented 9 months ago

Case 1: existing tests make use of OMPVV_TEST_SHARED_ENVIRONMENT; Because this macro is used for reporting purposes and has no effect on the program besides defining internal macro variables, no change is needed as long as the program does not depend on those internal variables (which is the actual case). Case 2: existing tests make use of OMPVV_TEST_AND_SET_SHARED_ENVIRONMENT(var2set); This can affect program behavior if var2set is used in the program. Thus, if the program relies on the previous definition logic, the test has to be changed. I found this to not be the case for existing tests, so no changes have to be made. Note: I have not included the Fortran tests into consideration, which I will change in a seperate PR.