OpenMP-Validation-and-Verification / OpenMP_VV

OpenMP Offloading Validation & Verification Suite; Official repository. We have migrated from bitbucket!! For documentation, results, publication and presentations, please check out our website ->
https://crpl.cis.udel.edu/ompvvsollve/
Other
54 stars 19 forks source link

Fix fixed-form Fortran quote and line-length issues #790

Closed tob2 closed 8 months ago

tob2 commented 9 months ago

Follow up to Pull Req. #616

The C preprocessor (cpp alias fpp) preprocessing fails here with:

ompvv/ompvv.F:343:26: warning: missing terminating " character
  343 |         PARAMETER (msg = "This tests is running on
      |                          ^
...
tests/5.2/implementation_defined/test_omx_fixed.F:30:25: warning: missing terminating ' character
   30 |         ! __FILE__ doesn't work
      |                         ^

which was fixed by adding some more " and " // to the code and avoiding the ' in the comment.

Additionally, without VERBOSE_MODE, the msg was not defined which caused errors due to implicit none; I now also enclose the user of msg in the #ifdef - alternatively, the declaration #ifdef could be removed.

And with VERBOSE_MODE, some lines were exceeding the 72 characters limits of fixed-form Fortran. Solution: some shifting of words and line breaks.

@krishols @spophale @fel-cab @nolanbaker31 — please review.