OpenMP-Validation-and-Verification / OpenMP_VV

OpenMP Offloading Validation & Verification Suite; Official repository. We have migrated from bitbucket!! For documentation, results, publication and presentations, please check out our website ->
https://crpl.cis.udel.edu/ompvvsollve/
Other
54 stars 19 forks source link

Missing taskwait in test_target_memcpy_async_no_obj.c #795

Closed brianwhitney59 closed 7 months ago

brianwhitney59 commented 7 months ago

There appears to be a missing $!omp taskwait after the first omp_target_memcpy_async call in test_target_memcpy_async_no_obj.c (5.1 test)

40     /* copy to target */
 41     omp_target_memcpy_async(mem_dev_cpy, mem, sizeof(double)*N,
 42                                 0,          0,
 43                                 t,          h,
 44                                 0,          NULL);
 45 
 46     #pragma omp taskwait   //<<<<<<<<<<<<<< this is not there and it is believed it is needed to allow the async to finish
 47     #pragma omp target is_device_ptr(mem_dev_cpy) device(t)
 48     #pragma omp teams distribute parallel for
 49     for(i = 0; i < N; i++){
 50         mem_dev_cpy[i] = i*2; // initialize data on device

This is using the Intel icpx compiler (internal version 2024.02.28) on Intel PVC GPUs.

The similar test test_target_memcpy_rect_async_obj_no.c includes the taskwait.

fel-cab commented 7 months ago

The fixed was merged in the Pull request #723