OpenMP-Validation-and-Verification / OpenMP_VV

OpenMP Offloading Validation & Verification Suite; Official repository. We have migrated from bitbucket!! For documentation, results, publication and presentations, please check out our website ->
https://crpl.cis.udel.edu/ompvvsollve/
Other
54 stars 19 forks source link

tests/6.0/target/test_target_nowait_argument.F90: Issue as '#' of '#include' is not in the first column #815

Closed tob2 closed 5 months ago

tob2 commented 5 months ago

First, I wonder whether the first 4 white spaces of the whole file shouldn't be removed ( → Pull Req. #811)

https://github.com/SOLLVE/sollve_vv/blob/b2743f89063fd313d022162fb1ae3c7fcf3c2b04/tests/6.0/target/test_target_nowait_argument.F90#L1-L9

However, the problem I have here is that gfortran's C preprocessor (built-in cpp) runs in traditional mode, which requires that the '#' is in the first line. If it isn't it complains as follows.

tests/6.0/target/test_target_nowait_argument.F90:9:6:

    9 |     #include "ompvv.F90"
      |      1
Error: Invalid character in name at (1)

I think it is not uncommon that a traditional-mode CPP is used as fancier C pre-processor features might have more issues (e.g. with Fortran comments, quotes inside quotes etc.), unless they have a notion of Fortran.

Possible solutions:

@spophale @fel-cab @andrewkallai @seyonglee