OpenMP-Validation-and-Verification / OpenMP_VV

OpenMP Offloading Validation & Verification Suite; Official repository. We have migrated from bitbucket!! For documentation, results, publication and presentations, please check out our website ->
https://crpl.cis.udel.edu/ompvvsollve/
Other
54 stars 19 forks source link

Resolving issue 817. #820

Closed spophale closed 4 months ago

spophale commented 5 months ago

closes #817

This resolves the missing data issue. But the test fails with both LLVM clang and amdclang as neither account for the stride specified in the target update.

Example:

#pragma omp target update from(s.data[:N/2:2]) //only update even array elements

Results in:

s.data[0]:10.000000 
s.data[1]:10.000000 
s.data[2]:10.000000 
s.data[3]:10.000000 
s.data[4]:10.000000 
s.data[5]:0.000000 
s.data[6]:0.000000 
s.data[7]:0.000000 
s.data[8]:0.000000 
s.data[9]:0.000000 
fel-cab commented 5 months ago

I see that the same problem with Cray compiler on NVIDIA GPU system. While nvc, and gcc have not implemented mapper (it seems). I would suggest to change the double to int, so we can compare equality without the problems that could happen with floating point numbers.