search

OpenMPDK / SMDK

SMDK, Scalable Memory Development Kit, is developed for Samsung CXL(Compute Express Link) Memory Expander to enable full-stack Software-Defined Memory system
271 stars 60 forks source link

Linux Kernel Compilation failure because of the change in __GFP_BITS_SHIFT definition with smdk_v1.2 tag #12

Closed vjonnal closed 2 years ago

vjonnal commented 2 years ago

https://github.com/OpenMPDK/SMDK/blob/9ebacf0fa9ff0a0926ad0380346def548813228d/lib/linux-5.18-rc3-smdk/include/linux/gfp.h#L280

The check in the below line is failing because of the change in __GFP_BITS_SHIFT definition. https://github.com/OpenMPDK/SMDK/blob/9ebacf0fa9ff0a0926ad0380346def548813228d/lib/linux-5.18-rc3-smdk/lib/radix-tree.c#L1597

KyungsanKim commented 2 years ago

Hi, i'm sorry for your inconvenience. We checked that kernel build failure can happen depending on kernel configs. We will push a patch soon.

For us to better support you, please let us know information below.

  1. kernel config you are using on the error:

    CONFIG_EXMEM is enabled=yes |no CONFIG_PROVE_LOCKING=yes|no CONFIG_LOCK_STAT=yes|no CONFIG_DEBUG_LOCK_ALLOC=yes|no CONFIG_LOCKDEP=yes|no

  2. OS distro:

  3. System / CPU:

  4. Your organization : personal / industry

vjonnal commented 2 years ago

Hello, Thank you for your response. Following are the details that you have asked.

  1. kernel config CONFIG_EXMEM=yes CONFIG_PROVE_LOCKING=no CONFIG_LOCK_STAT=no CONFIG_DEBUG_LOCK_ALLOC=no CONFIG_LOCKDEP=yes
  2. OS Distro: Ubuntu 21.10
  3. System/CPU: AMD EPYC 7452
  4. Personal interest.
KyungsanKim commented 2 years ago

Hi, Thank you for the reply. As a workaround, configuring "CONFIG_EXMEM=yes and CONFIG_LOCKDEP=no" will disappear the build issue, we are preparing a patch , though. By the way, is there a specific hack you want to do with the lockdep function?

vjonnal commented 2 years ago

Nothing specific with LOCKDEP, I removed the config and verified that the compilation issue is resolved. Just wanted to keep you informed. Will wait for the patch. Thank you.

KyungsanKim commented 2 years ago

Thank you for informing us, Ravi Shankar.

Patch is updated : release - https://github.com/OpenMPDK/SMDK/releases/tag/smdk_v1.2.1 commit - https://github.com/OpenMPDK/SMDK/commit/2cd3b4b514c9095343037cce62f7db6492ad93a4

Please check and kindly let us know if you get to know another issue.

vjonnal commented 2 years ago

Verified that kernel compilation issue is solved with smdk_v1.2.1 tag. Closing the issue.